-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed compatibility with PHP 8.2+ #638
Conversation
When PHP8.2 built with
It looks like the "tentative" return type doesn't work in this case. I thought, that it would be easier just to define the method that corresponds the interface |
59c5bcc
to
1476190
Compare
It may be worth adding 8.2 and 8.3 in the test runner... |
51d1097
to
47da661
Compare
It looks like 8.2 does not accept "tentative" void type
47da661
to
5e0646c
Compare
@mikhainin have you tried PR #616 ? |
Actually, no. I'm afraid I didn't see that one |
I think this is not needed after merging #616 ? I will add PHP 8.2 to the test runner. |
It looks like 8.2 does not accept "tentative" void type