Add repr(C) to unions to ensure variants are laid out at the start #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this bug when investigating use cases for the lint proposed rust-lang/rust-clippy#8289 (comment)
If a union doesn't have a
#[repr(C)]
attribute on it, the two variants do not have to be laid out both starting at offset 0. It would be perfectly valid to treat thatunion
keyword as astruct
keyword, and then suddenly you're reading uninit data / getting the wrong results.Source for this: https://doc.rust-lang.org/reference/types/union.html says