IECoreGL::Selector : Camera-space depth sampling #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmehl
commented
Feb 2, 2024
ericmehl
commented
Feb 2, 2024
johnhaddon
requested changes
Feb 5, 2024
ericmehl
force-pushed
the
OpenGLWorldDepth
branch
4 times, most recently
from
abd8d39 to
91a3646
Compare
|
Thanks John! I fixed the issues you pointed out and ready for a new look. |
|
Thanks Eric, LGTM. Could you squash down and merge please? Then we can get a release out so you can update your Gaffer PR... |
Previously, we were using OpenGL's depth buffer to sample depths. OpenGL stores depth samples in a quasi-NDC space range [0.0, 1.0]. This must then be converted to camera-space using a series of multiplication and additions, which accumulate floating point error. The end result can have significant error, especially when clipping planes are set far apart. This solution uses `geometryP` output from vertex shaders to get the camera-space Z value without precision-reducing floating point operations.
|
Squashed! |
ericmehl
force-pushed
the
OpenGLWorldDepth
branch
from
91a3646 to
6872587
Compare
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Feb 7, 2024
In ImageEngine/cortex#1404, we added this output to get un-normalized depth values for greater accuracy, so it is needed by the `StandardStyle` fragment shader as well.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Feb 19, 2024
In ImageEngine/cortex#1404, we added this output to get un-normalized depth values for greater accuracy, so it is needed by the `StandardStyle` fragment shader as well.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Feb 21, 2024
In ImageEngine/cortex#1404, we added this output to get un-normalized depth values for greater accuracy, so it is needed by the `StandardStyle` fragment shader as well.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Feb 23, 2024
In ImageEngine/cortex#1404, we added this output to get un-normalized depth values for greater accuracy, so it is needed by the `StandardStyle` fragment shader as well.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Feb 23, 2024
In ImageEngine/cortex#1404, we added this output to get un-normalized depth values for greater accuracy, so it is needed by the `StandardStyle` fragment shader as well.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Feb 29, 2024
In ImageEngine/cortex#1404, we added this output to get un-normalized depth values for greater accuracy, so it is needed by the `StandardStyle` fragment shader as well.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Mar 4, 2024
In ImageEngine/cortex#1404, we added this output to get un-normalized depth values for greater accuracy, so it is needed by the `StandardStyle` fragment shader as well.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Mar 5, 2024
In ImageEngine/cortex#1404, we added this output to get un-normalized depth values for greater accuracy, so it is needed by the `StandardStyle` fragment shader as well.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Mar 5, 2024
In ImageEngine/cortex#1404, we added this output to get un-normalized depth values for greater accuracy, so it is needed by the `StandardStyle` fragment shader as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using OpenGL's depth buffer to sample depths. OpenGL stores depth samples in a quasi-NDC space range [0.0, 1.0]. This must then be converted to camera-space using a series of multiplication and additions, which accumulate floating point error. The end result can have significant error, especially when clipping planes are set far apart.
This solution uses
geometryPoutput from vertex shaders to get the camera-space Z value without precision-reducing floating point operations.Checklist