VDBObject bindings : Adapt for OpenVDB 10.1 #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is essentially the same as the one we've used in Gaffer for interfacing with OpenColorIO bindings for a little while now.
The grid value class bindings are intended to provide everything both as an item (`["value"]`) and as an attribute (`.value`), but in OpenVDB 10.1 the item bindings seem broken, so we must use the attribute instead. Also added a missing import, and used `next()` to get the first element from `citerAllValues()`, knockin 2s off the runtime of the test.
OpenVDB 10.1 switched from Boost to PyBind11 for its bindings, so we need to bind VDBObject differently based on which version of OpenVDB we're building for. But with the new PyBindConverter class, the new bindings actually come out simpler than the old ones.
|
This will let us upgrade Gaffer to OpenVDB 10.1, which will in turn fix crashes caused by compiling OpenVDB 10.0 with GCC 11 - see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103629. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenVDB 10.1 switched from Boost to PyBind11 for its bindings, so we need to bind VDBObject differently based on which version of OpenVDB we're building for. But with the new PyBindConverter class, the new bindings actually come out simpler than the old ones.