Skip to content

Commit

Permalink
build(aio): disable 'global' support in webpack
Browse files Browse the repository at this point in the history
This will be fixed in CLI once angular/angular-cli#8130 lands.

-rw-r--r--  1 iminar  eng   14942 Oct 20 22:23 dist/0.b19e913fbdd6507d346b.chunk.js
-rw-r--r--  1 iminar  eng    1535 Oct 20 22:23 dist/inline.5d66b81ec9e01af9d28d.bundle.js
-rw-r--r--  1 iminar  eng  528395 Oct 20 22:23 dist/main.e36bb99245ca52ae546f.bundle.js
-rw-r--r--  1 iminar  eng   37205 Oct 20 22:23 dist/polyfills.0dfca732c5a075c110d0.bundle.js
  • Loading branch information
IgorMinar committed Nov 1, 2017
1 parent 0a7a4b0 commit 83f061b
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
7 changes: 4 additions & 3 deletions aio/tools/cli-patches/patch.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ const sh = require('shelljs');

const PATCH_LOCK = 'node_modules/@angular/cli/models/webpack-configs/.patched';

// if (!fs.existsSync(PATCH_LOCK)) {
// sh.touch(PATCH_LOCK);
// }
if (!fs.existsSync(PATCH_LOCK)) {
sh.exec('patch -p0 -i tools/cli-patches/webpack-no-global.patch');
sh.touch(PATCH_LOCK);
}

16 changes: 16 additions & 0 deletions aio/tools/cli-patches/webpack-no-global.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
--- node_modules/@angular/cli/models/webpack-configs/browser.js 2017-10-20 22:11:38.000000000 -0700
+++ node_modules/@angular/cli/models/webpack-configs/browser.js 2017-10-20 22:11:47.000000000 -0700
@@ -105,11 +105,11 @@
fs: 'empty',
// `global` should be kept true, removing it resulted in a
// massive size increase with Build Optimizer on AIO.
- global: true,
+ global: false,
crypto: 'empty',
tls: 'empty',
net: 'empty',
- process: true,
+ process: false,
module: false,
clearImmediate: false,
setImmediate: false

0 comments on commit 83f061b

Please sign in to comment.