Images 🌄 migration to GCP ⚓️ #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| export const PROGATE: string = 'https://storage.googleapis.com/ignitus_assets/ig-partners-logo/partnersLogo_progateLogo.png'; | ||
| export const LEANIN: string = 'https://storage.googleapis.com/ignitus_assets/ig-partners-logo/partnersLogo_leanLogo.png'; | ||
| export const GIRLSCRIPT: string = 'https://storage.googleapis.com/ignitus_assets/ig-partners-logo/partnersLogo_gsLogo.png'; | ||
| export const WOOTECH: string = 'https://storage.googleapis.com/ignitus_assets/ig-partners-logo/wooTech.png'; |
| @@ -1,2 +1,2 @@ | |||
| export const RESUME: string = 'https://storage.googleapis.com/ignitus_assets/ig-assets/Assets_Resume.svg'; | |||
| export const TORCH: string = 'https://storage.googleapis.com/ignitus_assets/ig-assets/Assets_torch.svg'; | |||
| export const RESUME: string = 'https://storage.googleapis.com/ignitus_assets/ig-assets/resume.svg'; | |||
| @@ -1,7 +1,7 @@ | |||
| //Ignitus utility classes | |||
|
|
|||
| .bg-triangle { | |||
| background: url('/images/split-blue-background.png') no-repeat; | |||
| background: url('/images/splitBlueBackground.png') no-repeat; | |||
| @@ -29,7 +29,7 @@ | |||
| } | |||
|
|
|||
| .intro__wrapper { | |||
| background: url('https://storage.googleapis.com/ignitus_assets/ig-assets/Assets_split-blue-background.png') no-repeat; | |||
| background: url('https://storage.googleapis.com/ignitus_assets/ig-assets/splitBlueBackground.png') no-repeat; | |||
There was a problem hiding this comment.
Line should be indented with spaces, not tabs
Prefer double-quoted strings
URL https://storage.googleapis.com/ignitus_assets/ig-assets/splitBlueBackground.png should not contain protocol or domain
| @@ -1,2 +1,2 @@ | |||
| export const studentAuth: string = 'https://storage.googleapis.com/ignitus_assets/ig-assets/Assets_studentAuth.svg'; | |||
| export const professorAuth: string = 'https://storage.googleapis.com/ignitus_assets/ig-assets/Assets_professorAuth.svg'; | |||
| export const studentAuth: string = 'https://storage.googleapis.com/ignitus_assets/ig-assets/studentAuthentication.svg'; | |||
| @@ -1,6 +1,6 @@ | |||
| /* eslint-disable eol-last */ | |||
| // eslint-disable-next-line import/prefer-default-export | |||
| export const aboutImg: string = 'https://storage.googleapis.com/ignitus_assets/ig-assets/Assets_about-us.png'; | |||
| export const aboutImg: string = 'https://storage.googleapis.com/ignitus_assets/ig-assets/about.png'; | |||
Codecov Report
@@ Coverage Diff @@
## develop #708 +/- ##
=============================================
Coverage 15.95745% 15.95745%
=============================================
Files 45 45
Lines 376 376
Branches 82 82
=============================================
Hits 60 60
Misses 316 316
Continue to review full report at Codecov.
|
This was referenced Mar 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images 🌄 migration to GCP ⚓️