Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added text area component #773

Merged
merged 79 commits into from
Oct 6, 2023
Merged

feat: Added text area component #773

merged 79 commits into from
Oct 6, 2023

Conversation

rkaraivanov
Copy link
Member

Closes #764

@rkaraivanov rkaraivanov force-pushed the rkaraivanov/textarea branch from 8d0f6d6 to 4f7bac5 Compare June 13, 2023 07:56
simeonoff and others added 11 commits June 14, 2023 10:33
@simeonoff
Merge branch 'master' into rkaraivanov/textarea
9bc7263
@rkaraivanov
Merge branch 'master' of https://github.com/IgniteUI/igniteui-webcomp…
88b3975 
…onents into rkaraivanov/textarea
@rkaraivanov
Merge branch 'rkaraivanov/textarea' of https://github.com/IgniteUI/ig…
e86076c 
…niteui-webcomponents into rkaraivanov/textarea
@rkaraivanov
Merge branch 'master' of https://github.com/IgniteUI/igniteui-webcomp…
74e2c2b 
…onents into rkaraivanov/textarea
@rkaraivanov
fix: Delegate focus refactor. A11y improvements.
680dadb
@rkaraivanov
Merge branch 'master' of https://github.com/IgniteUI/igniteui-webcomp…
61b44ad 
…onents into rkaraivanov/textarea
@rkaraivanov
fix: Focus/blur handling, lit-analyzer errors
046ceb8
@SisIvanova
feat(textarea): component styling
a0b45bc
@rkaraivanov
Merge branch 'rkaraivanov/textarea' of https://github.com/IgniteUI/ig…
2f12a8e 
…niteui-webcomponents into rkaraivanov/textarea
@rkaraivanov
chore: Clean-ups after merge
6308971
@rkaraivanov
Merge branch 'master' of https://github.com/IgniteUI/igniteui-webcomp…
4e0c330 
…onents into rkaraivanov/textarea
@rkaraivanov
Copy link
Member Author

rkaraivanov commented Jun 27, 2023 •
edited
Loading

@SisIvanova

I thought that sizing was done through CSS variables in new components. Can you remove the SizableMixin and style it based on the CSS variable?

SisIvanova
SisIvanova reviewed Jun 28, 2023
View reviewed changes
src/components/textarea/textarea.ts Outdated Show resolved Hide resolved
src/components/textarea/textarea.ts Outdated Show resolved Hide resolved
SisIvanova and others added 12 commits June 28, 2023 10:13
@SisIvanova
fix(textarea): material theme omissions
d7f153f
@rkaraivanov
refactor: Template rendering
96e9239
@rkaraivanov
Merge branch 'master' of https://github.com/IgniteUI/igniteui-webcomp…
d516594 
…onents into rkaraivanov/textarea
@SisIvanova
fix(textarea): sizing & hide prefix/suffix parts
12d3739
@rkaraivanov
Merge branch 'master' of https://github.com/IgniteUI/igniteui-webcomp…
2be0eb3 
…onents into rkaraivanov/textarea
@SisIvanova
feat(textarea): required & disabled
f8e99f4
@SisIvanova
Merge branch 'master' into rkaraivanov/textarea
9a8fdc6
@SisIvanova
fix(textarea): lint errors
7f9fb2c
@rkaraivanov
Merge branch 'master' of https://github.com/IgniteUI/igniteui-webcomp…
8f60d4c 
…onents into rkaraivanov/textarea
@rkaraivanov
chore: Textarea stories types
aa7dec1
@SisIvanova
feat(textarea): invalid styles
8a84841
@rkaraivanov
refactor: Removed horizontal resizing
74e550c
simeonoff
simeonoff requested changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styles need some minor changes.

src/components/textarea/themes/light/textarea.base.scss Outdated Show resolved Hide resolved
src/components/textarea/themes/light/textarea.base.scss Outdated Show resolved Hide resolved
src/components/textarea/themes/light/textarea.base.scss Outdated Show resolved Hide resolved
src/components/textarea/themes/light/textarea.bootstrap.scss Outdated Show resolved Hide resolved
src/components/textarea/themes/light/textarea.bootstrap.scss Outdated Show resolved Hide resolved
@simeonoff
Copy link
Collaborator

@desig9stein can you validate the implemented component against angular for differences?

@simeonoff simeonoff self-requested a review October 2, 2023 11:02
@desig9stein
Copy link
Contributor

@SisIvanova I spotted a few things.

  1. There are colors in the textarea.base.scss. base files should not have colors.
  2. Color transitions in all themes except fluent are different from angular.
  3. Material box type in angular has animation on focus, the blue line is animated from the center to the sides
  4. No need to import @use 'sass:map'; if it's not used In the file.

@simeonoff simeonoff merged commit 8ce18d4 into master Oct 6, 2023
@simeonoff simeonoff deleted the rkaraivanov/textarea branch October 6, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SisIvanova SisIvanova SisIvanova left review comments

@simeonoff simeonoff simeonoff approved these changes

Assignees

@desig9stein desig9stein

Labels
design: awaiting-validation squash-merge text area ✅ status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text-area like input component
5 participants
@rkaraivanov @simeonoff @desig9stein @SisIvanova @kdinev