Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use case navigation prototype #168

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use case navigation prototype #168

wants to merge 5 commits into from

Conversation

meyerweb
Copy link
Member

@meyerweb meyerweb commented Apr 11, 2023

@meyerweb meyerweb requested a review from bkardell as a code owner April 11, 2023 19:40
@meyerweb
Copy link
Member Author

meyerweb commented Apr 11, 2023

I thought the site preview would build what this is meant to do, but it appears to build master without the changes in this pull request. That’s rather frustrating.

@bkardell
Copy link
Member

I'd love to understand why that preview didn't build - works for me locally just fine, I don't see any obvious errors in the actions.

In any case my main worry here is accessibility. There isn't even unforunately a good, established definition of what a carousel is/isn't and how to make it accessible. Tons of them just aren't and because things are sometimes subtley different it's hard to just define one that works for everything. Like, we had one on the old site too https://github.com/Igalia/wpewebkit.org/blob/issue53/index.html but part of the reason that 'worked' (if it did, really) is because each unit in there was a window/tab stop that contained the content on it's own.. So, we just made the buttons spans and even aria hid them I think. It's just a scroll. Here they are buttons which means you'll tab stops for them that just announce "greater than" or "less than" and the document itself doesn't change in a way that will be detected. So... idk, maybe all we need to do is (counterintuitively) make them not buttons and hide them?

@meyerweb
Copy link
Member Author

In any case my main worry here is accessibility.

This being a prototype, things like accessibility (and responsiveness for mobile) haven’t been addressed yet. I leave those for when the overall concept has been approved, since there’s always the chance people will get their hands on the live prototype and decide it’s not the right way to go. We might, for example, decide that instead of arrows you have to click or tap, we pick random use case for each page load, to be shown statically. Or we set it up such that for a given day, one use case is featured, a different one the next day, another the next day, and so on. (Looping back to the first to start the cycle over again once you’ve run through all the use cases.)

@bkardell
Copy link
Member

@aperezdc shouldn't this preview work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants