Added AsNoTracking for readonly queries

src/IdentityServer4.EntityFramework/Services/CorsPolicyService.cs

@@ -9,6 +9,7 @@
 using IdentityServer4.EntityFramework.Interfaces;
 using Microsoft.Extensions.Logging;
 using Microsoft.AspNetCore.Http;
+using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
 
 namespace IdentityServer4.EntityFramework.Services
@@ -44,7 +45,7 @@ public Task<bool> IsOriginAllowedAsync(string origin)
             // doing this here and not in the ctor because: https://github.com/aspnet/CORS/issues/105
             var dbContext = _context.HttpContext.RequestServices.GetRequiredService<IConfigurationDbContext>();
 
-            var origins = dbContext.Clients.SelectMany(x => x.AllowedCorsOrigins.Select(y => y.Origin)).ToList();
+            var origins = dbContext.Clients.SelectMany(x => x.AllowedCorsOrigins.Select(y => y.Origin)).AsNoTracking().ToList();
 
             var distinctOrigins = origins.Where(x => x != null).Distinct();
 

src/IdentityServer4.EntityFramework/Stores/ClientStore.cs

@@ -54,6 +54,7 @@ public Task<Client> FindClientByIdAsync(string clientId)
                 .Include(x => x.IdentityProviderRestrictions)
                 .Include(x => x.AllowedCorsOrigins)
                 .Include(x => x.Properties)
+                .AsNoTracking()
                 .FirstOrDefault(x => x.ClientId == clientId);
             var model = client?.ToModel();
 

src/IdentityServer4.EntityFramework/Stores/PersistedGrantStore.cs

@@ -75,7 +75,7 @@ public Task StoreAsync(PersistedGrant token)
         /// <returns></returns>
         public Task<PersistedGrant> GetAsync(string key)
         {
-            var persistedGrant = _context.PersistedGrants.FirstOrDefault(x => x.Key == key);
+            var persistedGrant = _context.PersistedGrants.AsNoTracking().FirstOrDefault(x => x.Key == key);
             var model = persistedGrant?.ToModel();
 
             _logger.LogDebug("{persistedGrantKey} found in database: {persistedGrantKeyFound}", key, model != null);
@@ -90,7 +90,7 @@ public Task<PersistedGrant> GetAsync(string key)
         /// <returns></returns>
         public Task<IEnumerable<PersistedGrant>> GetAllAsync(string subjectId)
         {
-            var persistedGrants = _context.PersistedGrants.Where(x => x.SubjectId == subjectId).ToList();
+            var persistedGrants = _context.PersistedGrants.Where(x => x.SubjectId == subjectId).AsNoTracking().ToList();
             var model = persistedGrants.Select(x => x.ToModel());
 
             _logger.LogDebug("{persistedGrantCount} persisted grants found for {subjectId}", persistedGrants.Count, subjectId);

src/IdentityServer4.EntityFramework/Stores/ResourceStore.cs

@@ -54,7 +54,7 @@ from apiResource in _context.ApiResources
                     .ThenInclude(s => s.UserClaims)
                 .Include(x => x.UserClaims);
 
-            var api = apis.FirstOrDefault();
+            var api = apis.AsNoTracking().FirstOrDefault();
 
             if (api != null)
             {
@@ -79,7 +79,7 @@ public Task<IEnumerable<ApiResource>> FindApiResourcesByScopeAsync(IEnumerable<s
 
             var query =
                 from api in _context.ApiResources
-                where api.Scopes.Where(x=>names.Contains(x.Name)).Any()
+                where api.Scopes.Where(x => names.Contains(x.Name)).Any()
                 select api;
 
             var apis = query
@@ -88,7 +88,7 @@ where api.Scopes.Where(x=>names.Contains(x.Name)).Any()
                     .ThenInclude(s => s.UserClaims)
                 .Include(x => x.UserClaims);
 
-            var results = apis.ToArray();
+            var results = apis.AsNoTracking().ToArray();
             var models = results.Select(x => x.ToModel()).ToArray();
 
             _logger.LogDebug("Found {scopes} API scopes in database", models.SelectMany(x => x.Scopes).Select(x => x.Name));
@@ -113,7 +113,7 @@ where scopes.Contains(identityResource.Name)
             var resources = query
                 .Include(x => x.UserClaims);
 
-            var results = resources.ToArray();
+            var results = resources.AsNoTracking().ToArray();
 
             _logger.LogDebug("Found {scopes} identity scopes in database", results.Select(x => x.Name));
 
@@ -127,19 +127,21 @@ where scopes.Contains(identityResource.Name)
         public Task<Resources> GetAllResourcesAsync()
         {
             var identity = _context.IdentityResources
-              .Include(x => x.UserClaims);
+              .Include(x => x.UserClaims)
+              .AsNoTracking();
 
             var apis = _context.ApiResources
                 .Include(x => x.Secrets)
                 .Include(x => x.Scopes)
-                    .ThenInclude(s => s.UserClaims)
-                .Include(x => x.UserClaims);
+                .ThenInclude(s => s.UserClaims)
+                .Include(x => x.UserClaims)
+                .AsNoTracking();
 
             var result = new Resources(
                 identity.ToArray().Select(x => x.ToModel()).AsEnumerable(),
                 apis.ToArray().Select(x => x.ToModel()).AsEnumerable());
 
-            _logger.LogDebug("Found {scopes} as all scopes in database", result.IdentityResources.Select(x=>x.Name).Union(result.ApiResources.SelectMany(x=>x.Scopes).Select(x=>x.Name)));
+            _logger.LogDebug("Found {scopes} as all scopes in database", result.IdentityResources.Select(x => x.Name).Union(result.ApiResources.SelectMany(x => x.Scopes).Select(x => x.Name)));
 
             return Task.FromResult(result);
         }