This repository has been archived by the owner on Mar 3, 2022. It is now read-only.
feat: merge openid-configuration and metdata #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, We are using this library, and facing some issue after this change, because we assumed that the 'injected' metadata has precedence over the 'openid-configuration'. Is there a way the force this behavior? |
oklas
added a commit
to oklas/oidc-client-js
that referenced
this pull request
Feb 5, 2021
|
I suggests solution #1295 which save this behaviour and avoid mentioned issue after this change. Customisation of providers configuration here is also necessary. |
|
Sorry @dopry -- I had to change how your PR worked. I added a new |
|
no worries! I was just scratching my own itch at the time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the .well-known/openid-configuration over any injected configuration in settings.metadata to allow clients to specify properties missing in their OIDC servers openid-configuration. This is specifically to make life easier with Auth0 or other poorly implemented OIDC servers while waiting on them to get their acts together.
applies to #1067