Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace fail module with thiserror #96

Closed
wants to merge 4 commits into from

Conversation

waynr
Copy link
Contributor

@waynr waynr commented May 17, 2020

Addresses #75
Builds on #95 (because the compiler warnings were annoying me)

While this is largely a cleanup PR it does make a couple significant changes:

  • Renames ErrorKind -> DockworkerError (I have no problem with changing this back, I just thought it was better to be more descriptive for the sake of external uses that might import it)
  • Removes the var field from Dockworker::InvalidUri since uri parsing is only done during creation of HyperClient connections whose errors are ultimately wrapped in Dockworker::CouldNotConnect which already includes the same information.

@waynr
Copy link
Contributor Author

waynr commented May 17, 2020

I'm not too familiar with CircleCI, but it appears that in order to view the CI job results I have to log into their website and I'd rather not.

@eldesh Is there a way to make the CI job results visible to shmucks like me?

@dalance dalance mentioned this pull request Jun 15, 2022
@eldesh
Copy link
Collaborator

eldesh commented Jun 17, 2022

@dalance (#122) made a similar (but newer) change. Thank you very much.

@eldesh eldesh closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants