Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate container test #112

Merged
merged 12 commits into from
Jul 25, 2022
Merged

Integrate container test #112

merged 12 commits into from
Jul 25, 2022

Conversation

eldesh
Copy link
Collaborator

@eldesh eldesh commented Feb 15, 2021

close #70

  • Performs unit tests sequentially
  • Add some container api calls to the test

This change lead to:

  • Reduces dependency on various versions of the alpine image
    • before: alpine: 3.4, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10 and latest
    • after: alpine: 3.9 and 3.10

@eldesh eldesh force-pushed the integrate-container-test branch 2 times, most recently from a1b3d78 to eaa611a Compare February 15, 2021 05:15
@eldesh eldesh marked this pull request as ready for review February 15, 2021 06:20
@eldesh eldesh requested a review from nyuichi February 15, 2021 06:21
@nyuichi
Copy link
Contributor

nyuichi commented Feb 15, 2021

@eldesh May I ask @pandaman64 to take over the review from me? He is interested in maintaining this project, and reviewing this PR should be a good starting point for joining us.

@eldesh
Copy link
Collaborator Author

eldesh commented Feb 15, 2021

That looks good 🙆

@nyuichi nyuichi requested a review from pandaman64 February 15, 2021 14:17
@eldesh
Copy link
Collaborator Author

eldesh commented Mar 1, 2021

@pandaman64 How about it? 👀

@pandaman64
Copy link

I'm really sorry that I have not started the review yet, and I have no room for this until next week.

@eldesh
Copy link
Collaborator Author

eldesh commented Mar 1, 2021

I understand.
I would be grateful if you could review it when you have time.

@eldesh eldesh force-pushed the integrate-container-test branch from eaa611a to e3a3143 Compare July 15, 2022 08:15
@eldesh eldesh requested a review from hioki July 22, 2022 04:48
@eldesh eldesh mentioned this pull request Jul 22, 2022
Copy link

@hioki hioki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldesh eldesh merged commit ea4a942 into master Jul 25, 2022
@eldesh eldesh deleted the integrate-container-test branch July 25, 2022 08:00
@eldesh eldesh mentioned this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform unit tests sequentially
4 participants