Created SwiftSensor class and reworked reportDirectory into reportsInRoot #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created SwiftSensor abstract class, which SwiftLintSensor and SwiftCoberturaSensor extend - Removed ReportFilesFinder. Report finding functionality moved to Util, and settings reading functionality moved to SwiftSensor - Reworked reportDirectory to reportInRoot, which makes reportPattern / reportPath evaluated from the project root - Cleaned up CoberturaReportParser and SwiftLintReportParser - Reworked ReportFilesFinderTest to SwiftSensorTest
|
Please fix the conflicts before any review @isaacwang4076. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make the addition of new Sensors as easy as extending the SwiftSensor class which offers modular support and report location off the bat and adding a new report parser. I realize there's a lot of changes, feel free to send me any questions or concerns.