Enhance column suggestion differentiation #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
enhance-column-suggestion-differentation
branch
2 times, most recently
from
22945cf
to
e2a6286
Compare
The title shows the actual column path. Should make the differentation of equally labelled columns easier.
nilmerg
force-pushed
the
enhance-column-suggestion-differentation
branch
from
e2a6286
to
b5228db
Compare
nilmerg
added a commit
that referenced
this pull request
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows the relation name now in case a concrete implementation of
Suggestions::shouldShowRelationFor()returnstrue.In addition, an accepted column suggestion now defines a title which is used for the target input. This way a user exactly knows which input represents which column by hovering over it.
An example how this will look like:
