Process POST requests in SortControl
#173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
feature/sort-control-post-support-172
branch
from
96ca6b3
to
8027ca0
Compare
nilmerg
force-pushed
the
feature/sort-control-post-support-172
branch
from
8027ca0
to
3cd95ba
Compare
nilmerg
added a commit
to Icinga/icingaweb2-module-businessprocess
that referenced
this pull request
Aug 3, 2023
resolves #252 closes #297 requires Icinga/ipl-web#173
A future update will remove support for the $url parameter and the columns are mandatory anyway. And since we use late static binding in self::create(), we can guarantee that the instance creation will always succeed. Currently, no released code uses the constructor directly, so it's safe to adjust the visiblity.
If `CompatController::createSortControl()` is not used, handleRequest may not be called. This is the case for Icinga DB Web < 1.1 and Icinga Web Graphite integration <= 1.2.3. Should be easily reverted.
Icinga Cube does not even use `CompatController::createSortControl()` or a custom override like Icinga Web Graphite Integration. Therefore, unless it calls handleRequest(), we still need to load the sort rule from the request in getSort() directly. Should be easily reverted.
nilmerg
force-pushed
the
feature/sort-control-post-support-172
branch
from
3cd95ba
to
981f105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #172
closes #74