Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompatForm: Register form element namespace #127

Merged
merged 1 commit into from
Jun 23, 2023
Merged

CompatForm: Register form element namespace #127

merged 1 commit into from
Jun 23, 2023

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Mar 21, 2023 •
edited
Loading

blocked by Icinga/ipl-html#124

@nilmerg nilmerg self-assigned this Mar 21, 2023
@cla-bot cla-bot bot added the cla/signed label Mar 21, 2023
@nilmerg nilmerg force-pushed the register-element-namespace-in-compat-form branch from e2a835c to f5bafb3 Compare March 21, 2023 13:58
@nilmerg nilmerg marked this pull request as draft March 21, 2023 14:06
@nilmerg
Copy link
Member Author

nilmerg commented Mar 21, 2023

Nope. Not in the constructor. But ensureDefaultElementLoaderRegistered is not an option as $defaultElementLoaderRegistered is private -.-. I won't change it's visibility now, though.

@nilmerg nilmerg force-pushed the register-element-namespace-in-compat-form branch from f5bafb3 to 92ef382 Compare June 23, 2023 08:39
@nilmerg nilmerg added this to the v0.9.0 milestone Jun 23, 2023
@nilmerg nilmerg added the enhancement New feature or request label Jun 23, 2023
@nilmerg nilmerg marked this pull request as ready for review June 23, 2023 08:46
@nilmerg nilmerg merged commit 6ad9c0a into main Jun 23, 2023
@nilmerg nilmerg deleted the register-element-namespace-in-compat-form branch June 23, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nilmerg nilmerg

Labels
cla/signed enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@nilmerg