Merged
Conversation
|
There is still one call to |
sukhwinder33445
force-pushed
the
support-php-85
branch
from
c035917 to
c9e39d5
Compare
BastianLedererIcinga
previously approved these changes
Dec 4, 2025
sukhwinder33445
force-pushed
the
support-php-85
branch
from
c9e39d5 to
10922e2
Compare
BastianLedererIcinga
previously approved these changes
Dec 5, 2025
sukhwinder33445
force-pushed
the
support-php-85
branch
2 times, most recently
from
2ec22a0 to
1bece9a
Compare
sukhwinder33445
force-pushed
the
support-php-85
branch
from
1bece9a to
f5c83a3
Compare
lippserd
force-pushed
the
support-php-85
branch
from
838d586 to
5f95e6f
Compare
Streamline with Icinga/icinga-php-thirdparty#82
Otherwise, we would have to increase `guzzlehttp/psr7` (ddd7fa8) to support recent PHP versions. This is a bit excessive for a library from which we only need a single class exclusively for testing: The `UploadedFile` class was only used to test our `FileValidator` and is now replaced by a minimal implementation of `PSR-7#UploadedFileInterface`.
lippserd
force-pushed
the
support-php-85
branch
from
5f95e6f to
58f440c
Compare
lippserd
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.5 related changes:
SplObjectStorageOther changes:
UpgradeInstead, remove dependency toguzzlehttp/psr7to streamline with Support PHP 8.5 icinga-php-thirdparty#82.guzzlehttp/psr7used just for testingresolves #37