Fix full circle pie slice (100%) drawing #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows getPieSlicePath to draw a full circle pie slice (100%) by slightly adjusting endpoint to have a valid arc. Also hides a central line as there will be no more pie slices.
The getPieSlicePath primitive can draw it now.
Having a single hostgroup, and all hosts and services up, landing page Pie Chart is empty. This restores display of OK hosts and services.
|
Thanks for the patches! Could you please open a referencing issue at https://dev.icinga.org/projects/icingaweb2?jump=welcome so that the web developers may review it and schedule it for the next milestone. Thanks! |
|
Hi, Thanks for the patches. I created an issue at https://dev.icinga.org/projects/icingaweb2?jump=welcome: https://dev.icinga.org/issues/6976. If it has been reviewed, I'll merge your pull request. Cheers, |
|
Hi, Sorry for the late response. Your commits are in the master branch already. I'll close this one. Cheers, |
DMajrekar
added a commit
to DMajrekar/icingaweb2
that referenced
this pull request
Nov 30, 2015
When users are in a different BaseDN to the groups, this causes no groups to be loaded out of Ldap. The following error is given:
2015-11-30T08:29:51+00:00 - ERROR - Stacktrace: #0 [internal function]: Icinga\Application\ApplicationBootstrap->Icinga\Application\{closure}(2, 'strpos(): Empty...', '/icingaweb2/lib...', 88, Array)
Icinga#1 /icingaweb2/library/Icinga/Repository/LdapRepository.php(88): strpos('<USER DN>', '')
Icinga#2 /icingaweb2/library/Icinga/Authentication/UserGroup/LdapUserGroupBackend.php(394): Icinga\Repository\LdapRepository->isRelatedDn('<USER DN>')
Icinga#3 /icingaweb2/library/Icinga/Authentication/UserGroup/LdapUserGroupBackend.php(487): Icinga\Authentication\UserGroup\LdapUserGroupBackend->isMemberAttributeAmbiguous()
Icinga#4 /icingaweb2/library/Icinga/Repository/Repository.php(436): Icinga\Authentication\UserGroup\LdapUserGroupBackend->initializeConversionRules()
Icinga#5 /icingaweb2/library/Icinga/Repository/Repository.php(590): Icinga\Repository\Repository->getConversionRules()
Icinga#6 /icingaweb2/library/Icinga/Repository/RepositoryQuery.php(329): Icinga\Repository\Repository->providesValueConversion('group', 'group_name')
Icinga#7 /icingaweb2/library/Icinga/Web/Widget/SortBox.php(126): Icinga\Repository\RepositoryQuery->order('group_name', 'asc')
Icinga#8 /icingaweb2/library/Icinga/Web/Controller.php(117): Icinga\Web\Widget\SortBox->handleRequest(Object(Icinga\Web\Request))
Icinga#9 /icingaweb2/application/controllers/GroupController.php(74): Icinga\Web\Controller->setupSortControl(Array, Object(Icinga\Repository\RepositoryQuery))
Icinga#10 /icingaweb2/library/vendor/Zend/Controller/Action.php(507): Icinga\Controllers\GroupController->listAction()
Icinga#11 /icingaweb2/library/Icinga/Web/Controller/Dispatcher.php(76): Zend_Controller_Action->dispatch('listAction')
Icinga#12 /icingaweb2/library/vendor/Zend/Controller/Front.php(937): Icinga\Web\Controller\Dispatcher->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
Icinga#13 /icingaweb2/library/Icinga/Application/Web.php(361): Zend_Controller_Front->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
Icinga#14 /icingaweb2/library/Icinga/Application/webrouter.php(109): Icinga\Application\Web->dispatch()
Icinga#15 /icingaweb2/public/index.php(4): require_once('/icingaweb2/lib...')
Icinga#16 {main}
This was referenced Jan 17, 2017
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a single hostgroup, and all hosts and services up, landing page Pie Chart is empty. This patch set restores display of OK hosts and services. As a follow up, getPieSlicePath primitive can draw nice looking full circle pie slice.