Don't call session_start() after ini_set() #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirming - this patch completely fixes the php-7.2 issue for me - I've been running with this patch for some weeks now against -master, with no other problems. Hopefully this patch can be merged soon. |
Al2Klimov
requested review from
lippserd
and removed request for
Thomas-Gelf and
nilmerg
|
We recently updated to Ubuntu 18.04, and are experiencing the same issue as this bug report was for.
How do I best update this to newest version for bionic? |
|
Wait until 2.6 is officially released, or use the patchset as a workaround meanwhile. |
|
Thanks - is it still ETA end of this month for 2.6? Just trying to decide if we can limp along until 2.6, or we need to roll back to PHP 7.1? |
|
@pillbug22 Yes I think we can manage that 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3185