Open
Conversation
The method signature of `Zend_Form_Element::_filterValue()` was changed years ago in `shardj/zf1-future`, but we provided a patch so that Director did not need to be modified to maintain compatibility between multiple library versions. With the upcoming support for PHP 8.5, we no longer need to support older library versions and can adapt Director to be compatible with the changed signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method signature of
Zend_Form_Element::_filterValue()was changed years ago inshardj/zf1-future, but we provided a patch so that Director did not need to be modified to maintain compatibility between multiple library versions. With the upcoming support for PHP 8.5, we no longer need to support older library versions and can adapt Director to be compatible with the changed signature.refs Icinga/icinga-php-thirdparty#103