Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing nested values in import is non-ideal: fix option 1 #2584

Closed

Conversation

icanhazpython
Copy link

Fix option 1 for #2474

@cla-bot
Copy link

cla-bot bot commented Aug 14, 2022

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @icanhazpython

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@icanhazpython
Copy link
Author

CLA signed

@bobapple
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Aug 15, 2022
@Thomas-Gelf
Copy link
Contributor

Thank you for your pull request! I didn't merge this, as IMHO it SHOULD fail in case of conflicting types, like app being a string or an array (instead of an object) when accessing app.name:

  • { "app": null }: should shipnull
  • { "no app": "something" }: should ship null
  • { "app": "a string" }: should fail
  • { "app": false }: should fail
  • { "app": { "name": "app" }: should ship "app"

I'll push a related fix.

Thomas-Gelf added a commit that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants