Bump react/promise to 3.3.0 and remove clue/soap-react for PHP 8.5 support#93
Merged
Bump react/promise to 3.3.0 and remove clue/soap-react for PHP 8.5 support#93
react/promise to 3.3.0 and remove clue/soap-react for PHP 8.5 support#93Conversation
85e36b3 to
00935dd
Compare
f64eff3 to
b844df3
Compare
00935dd to
38bcad2
Compare
react/promise to version (3.3.0) for PHP 8.4/8.5 supportreact/promise to 3.3.0 and remove clue/soap-react for PHP 8.5 support
react/promise to 3.3.0 and remove clue/soap-react for PHP 8.5 supportreact/promise to 3.3.0 and remove clue/soap-react for PHP 8.5 support
This was referenced Feb 27, 2026
Merged
38bcad2 to
c799c4c
Compare
lippserd
approved these changes
Feb 27, 2026
Updates `react/promise` from 2.11.0 to 3.3.0 to support PHP 8.5: - PHP 8.4 support was introduced in 3.2.0: https://github.com/reactphp/promise/releases/tag/v3.2.0 - PHP 8.5 support was introduced in 3.3.0: https://github.com/reactphp/promise/releases/tag/v3.3.0 The `clue/soap-react` package was removed because it would prevent upgrading `react/promise`. `clue/soap-react` is not used in any of our modules or in third-party modules. The following commands were used for the upgrade: - `composer remove clue/soap-react` - `composer require react/promise` Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
c799c4c to
beea01b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
react/promisefrom 2.11.0 to 3.3.0 to support PHP 8.5:v3.2.0.v3.3.0.The
clue/soap-reactpackage was removed because it would prevent upgradingreact/promise.clue/soap-reactis not used in any of our modules or in third-party modules.The following commands were used for the upgrade:
composer remove clue/soap-reactcomposer require react/promiseresolves #87