Increase test coverage

Apply minor adjustments to the code and tests in order to provide maximum code coverage with unit tests.
Icikowski · Jun 15, 2022 · 247bd34 · 247bd34
1 parent 24f084f
commit 247bd34
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/application/service/builder.go b/application/service/builder.go
@@ -142,9 +142,7 @@ func PrepareServer(log zerolog.Logger, port int) *http.Server {
 	r.NotFoundHandler = getDefaultHandler(log)
 
 	log.Debug().Msg("registering shutdown hooks")
-	server.RegisterOnShutdown(func() {
-		health.ServiceStatus.MarkAsDown()
-	})
+	server.RegisterOnShutdown(health.ServiceStatus.MarkAsDown)
 
 	log.Info().Msg("server prepared")
 	return server

diff --git a/application/service/builder_test.go b/application/service/builder_test.go
@@ -52,6 +52,12 @@ func TestPrepareServer(t *testing.T) {
 			expectedStatus: http.StatusOK,
 			expectedKeys:   &[]string{"host", "path", "method", "headers", "queries"},
 		},
+		"get default endpoint with some queries": {
+			method:         http.MethodGet,
+			path:           "/?hello=world",
+			expectedStatus: http.StatusOK,
+			expectedKeys:   &[]string{"host", "path", "method", "headers", "queries"},
+		},
 		"get default endpoint on other path": {
 			method:         http.MethodGet,
 			path:           "/a/b/c",