Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM version to 2.10.4 #273

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Update NPM version to 2.10.4 #273

merged 1 commit into from
Sep 19, 2023

Conversation

jc21
Copy link
Contributor

@jc21 jc21 commented Sep 14, 2023

@jc21
Copy link
Contributor Author

jc21 commented Sep 14, 2023

Hi Team, it would be nice if I could edit the docker image tag for apps in the UI. I was hoping to have the docker image be something like

image: jc21/nginx-proxy-manager:${AppVersion:-2.10.4}

however, this requires that the AppVersion variable be configurable from the interface. Is this something that can be achieved currently?

@ETWang1991 ETWang1991 self-requested a review September 18, 2023 02:37
@ETWang1991 ETWang1991 self-assigned this Sep 18, 2023
@ETWang1991 ETWang1991 removed their request for review September 18, 2023 06:06
@ETWang1991
Copy link
Contributor

We will provide the installation of custom labels in a later version

@ETWang1991 ETWang1991 self-requested a review September 18, 2023 07:54
@tigerinus tigerinus merged commit 3298db3 into IceWhaleTech:main Sep 19, 2023
@jc21 jc21 deleted the npm branch September 19, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To be verified (QA)
Development

Successfully merging this pull request may close these issues.

3 participants