Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New App] Crafty Controller #260

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Conversation

charagender
Copy link
Contributor

Created and tested Crafty Controller app for CasaOS as per requested in #64

Crafty Controller is an open source Minecraft Server Control Panel made with the objective of making the management of Minecraft Servers easy.

Thoroughly tested in production and confirmed working.

image

Changed image tag from latest to release 4.1.3 to adhere with CasaOS' AppStore guidelines
@raller1028
Copy link
Contributor

@charagender
I'm sorry to inform you, as a fellow Minecraft enthusiast, that there are currently two issues with this app :(

The first is that the container name needs to be changed from crafty_container to crafty-container.

image

The second problem is that I can't get into the admin page after installing it, but I can see the log is fine, can you help me to see what the problem is?

image
image

@charagender
Copy link
Contributor Author

@raller1028

The first is that the container name needs to be changed from crafty_container to crafty-container.

Oh! Completely forgot to change that, thanks for pointing that out, will fix that later

The second problem is that I can't get into the admin page after installing it, but I can see the log is fine, can you help me to see what the problem is?

That's strange, I never encountered that error, though I do see you're using port 8110 for the web UI, as stated to be in the docker compose file, while I'm using port 8111 in my screenshots (will also fix the port_map value!). Can you confirm that the error still occurs when using port 8111?

@raller1028
Copy link
Contributor

raller1028 commented Aug 30, 2023

@charagender
Modify to https and use port 8111 for successful access!!!!
Maybe need to add tips "default username: admin, default password: crafty"
image
image

[IceWhaleTech#260 (comment)]
[IceWhaleTech#260 (comment)]
Fix container name from `crafty_container` to `crafty-container` so app can be installed.
Added before_install tips with default credentials.
Fixed scheme and port_map from http and 8110 to https and 8111 to fix bug where the web page would throw out an error.
@charagender
Copy link
Contributor Author

@raller1028 Thanks for confirming the fix worked! I've just committed the fix and added the before_install tips. I'd made them, but forgot to add them to the actual yaml file. Oops!

@raller1028 raller1028 merged commit 8111d0f into IceWhaleTech:main Sep 6, 2023
@tigerinus tigerinus linked an issue Sep 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[App Request] Crafty
2 participants