Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pick-cherry for fix unit #208

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: pick-cherry for fix unit #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pkg/docker/digest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ func TestGetManifest2(t *testing.T) {
runtime.GC()
}()

manifest, contentType, err := docker.GetManifest(context.Background(), "wangxiaohu/brother-cups:latest")
manifest, contentType, err := docker.GetManifest(context.Background(), "correctroad/logseq:latest")
assert.NilError(t, err)
assert.Equal(t, contentType, schema1.MediaTypeSignedManifest)
assert.Equal(t, contentType, "application/vnd.docker.distribution.manifest.v2+json")

var signedManifest schema1.SignedManifest
decoder, err := mapstructure.NewDecoder(&mapstructure.DecoderConfig{Result: &signedManifest, Squash: true})
Expand All @@ -115,7 +115,6 @@ func TestGetManifest2(t *testing.T) {
err = decoder.Decode(manifest)
assert.NilError(t, err)

assert.Assert(t, len(signedManifest.Architecture) > 0)
}

func TestGetManifest3(t *testing.T) {
Expand Down
6 changes: 6 additions & 0 deletions route/v2/appstore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,12 @@ func (a *AppManagement) UpgradableAppList(ctx echo.Context) error {
})
}
}

// sort upgradableAppList by title
sort.Slice(upgradableAppList, func(i, j int) bool {
return strings.Compare(upgradableAppList[i].Title, upgradableAppList[j].Title) < 0
})

return ctx.JSON(http.StatusOK, codegen.UpgradableAppListOK{
Data: &upgradableAppList,
})
Expand Down