fix: identify malformed QWeather forecasts - #35
Conversation
|
Warning Review limit reached
Next review available in: 20 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 39 39
Lines 5728 5748 +20
Branches 329 331 +2
=======================================
+ Hits 5700 5720 +20
Misses 17 17
Partials 11 11 ☔ View full report in Codecov by Harness. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Why
Missing QWeather daily fields previously surfaced only as
KeyError, which identified neither the parsing stage nor the missing contract field and made provider failures difficult to diagnose.Impact
Malformed QWeather forecasts now fail with actionable messages such as
daily forecast missing required field: tempMax. Raw provider response values and arbitrary exception messages remain excluded from diagnostics.Validation
prek run --all-filesuv run --with pytest --with pytest-cov -- pytest --cov --cov-branch --cov-report=xml