Skip to content

fix: add CAMS pollen attribution - #25

Merged
IceCodeNew merged 1 commit into
masterfrom
codex/cams-ensemble-attribution
Jul 14, 2026
Merged

fix: add CAMS pollen attribution#25
IceCodeNew merged 1 commit into
masterfrom
codex/cams-ensemble-attribution

Conversation

@IceCodeNew

Copy link
Copy Markdown
Owner

Summary

  • Show context-document names in rendered citations while preserving the existing generic label for RSS article links.
  • Attribute Open-Meteo pollen data to both Open-Meteo and CAMS ENSEMBLE in HTML and plain-text briefings.
  • Document the attribution source and deterministic rendering behavior.

Why

The Open-Meteo Air Quality API states that pollen values are provided by the CAMS European Air Quality forecast and requires clear attribution to CAMS ENSEMBLE together with a reference to Open-Meteo.

Validation

  • 411 tests passed
  • Local coverage: 99.67% lines, 98.18% branches
  • All prek hooks passed
  • Full diff manually reviewed

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@IceCodeNew, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a8f17a61-84e4-45c8-b6da-7d48f371d23c

📥 Commits

Reviewing files that changed from the base of the PR and between 57222ea and b8558de.

📒 Files selected for processing (6)
  • README.md
  • docs/design.md
  • tests/test_render.py
  • tests/test_weather_context.py
  • weather_briefing/render.py
  • weather_briefing/weather_context.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/cams-ensemble-attribution

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@IceCodeNew
IceCodeNew requested a review from Copilot July 14, 2026 17:59
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.46%. Comparing base (57222ea) to head (b8558de).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          38       38           
  Lines        5213     5224   +11     
  Branches      303      303           
=======================================
+ Hits         5185     5196   +11     
  Misses         17       17           
  Partials       11       11           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates pollen attribution to comply with Open-Meteo’s Air Quality API requirements by explicitly crediting CAMS ENSEMBLE, and improves citation rendering so context documents display their names while RSS article links keep the generic “来源” label.

Changes:

  • Update Open-Meteo allergen source_name to include “CAMS ENSEMBLE” and assert it in context parsing tests.
  • Render context document citations with the document name (HTML link text and plain-text name: url), while keeping RSS article citations as the generic “来源”.
  • Document the attribution source and deterministic rendering behavior in README and design docs.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
weather_briefing/weather_context.py Updates Open-Meteo pollen/allergen snapshot attribution name to include CAMS ENSEMBLE.
weather_briefing/render.py Changes citation rendering to show context document names (HTML + plain text) while preserving generic RSS labels.
tests/test_weather_context.py Adds coverage asserting the updated allergen attribution name.
tests/test_render.py Adds tests ensuring context document attribution is rendered deterministically in both renderers.
README.md Documents pollen attribution to Open-Meteo and CAMS ENSEMBLE.
docs/design.md Updates design documentation to reflect attribution requirements and rendering behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IceCodeNew
IceCodeNew marked this pull request as ready for review July 14, 2026 18:02
@IceCodeNew
IceCodeNew merged commit 2714507 into master Jul 14, 2026
21 checks passed
@IceCodeNew
IceCodeNew deleted the codex/cams-ensemble-attribution branch July 14, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants