fix: add CAMS pollen attribution - #25
Conversation
|
Warning Review limit reached
Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 38 38
Lines 5213 5224 +11
Branches 303 303
=======================================
+ Hits 5185 5196 +11
Misses 17 17
Partials 11 11 ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Pull request overview
This PR updates pollen attribution to comply with Open-Meteo’s Air Quality API requirements by explicitly crediting CAMS ENSEMBLE, and improves citation rendering so context documents display their names while RSS article links keep the generic “来源” label.
Changes:
- Update Open-Meteo allergen
source_nameto include “CAMS ENSEMBLE” and assert it in context parsing tests. - Render context document citations with the document name (HTML link text and plain-text
name: url), while keeping RSS article citations as the generic “来源”. - Document the attribution source and deterministic rendering behavior in README and design docs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| weather_briefing/weather_context.py | Updates Open-Meteo pollen/allergen snapshot attribution name to include CAMS ENSEMBLE. |
| weather_briefing/render.py | Changes citation rendering to show context document names (HTML + plain text) while preserving generic RSS labels. |
| tests/test_weather_context.py | Adds coverage asserting the updated allergen attribution name. |
| tests/test_render.py | Adds tests ensuring context document attribution is rendered deterministically in both renderers. |
| README.md | Documents pollen attribution to Open-Meteo and CAMS ENSEMBLE. |
| docs/design.md | Updates design documentation to reflect attribution requirements and rendering behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Why
The Open-Meteo Air Quality API states that pollen values are provided by the CAMS European Air Quality forecast and requires clear attribution to CAMS ENSEMBLE together with a reference to Open-Meteo.
Validation