fix(deps): update dependency cryptography to v50 - #131
Merged
Conversation
renovate
Bot
force-pushed
the
renovate/cryptography-50.x
branch
from
August 4, 2026 02:26
ce582b1 to
54cabe2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 139 139
Lines 13510 13510
Branches 785 785
=========================================
Hits 13510 13510 ☔ View full report in Codecov by Harness. |
IceCodeNew
added a commit
that referenced
this pull request
Aug 4, 2026
…136) PR #134 enabled all stable ruff rules, which left 13 lint errors on `master` and blocked renovate PR #131 (and every other PR). This fixes them on a fresh branch off `master`. ## Findings | Rule | Count | Resolution | | --- | --- | --- | | `PLR0917` too many positional args | 8 | structural fixes (see below) | | `ISC004` unparenthesized string concat in collection | 3 | wrapped in parens | | `RUF100` unused `BLE001` noqa | 2 | removed (ruff 0.16 no longer flags those sites) | ## PLR0917 — fixed by structure, not suppression The feedback on an earlier attempt was to avoid extending `noqa` whitelists where a real fix exists. Each site was evaluated individually: - **service-status state store + protocol** (`observe_service_status_message` / `mark_service_status_message_handled`): the monitor was hand-unpacking five `message` fields into every call. The store now takes the `ServiceStatusMessage` object directly. This removes the unpacking smell, not just the lint. Removes `# noqa: PLR0913` entirely. - **`BriefingService.__init__`**: made keyword-only — the only production call site (`cli.py`) now wires collaborators by name. - **`ServiceStatusMonitor.__init__`**: the optional `language` flag moves to keyword-only (idiomatic for defaulted params); 3 call sites updated. - **`test_factory_normalizes_provider_native_request_errors`**: parametrize dimensions moved to keyword-only (pytest 9 supports this). - **`_briefing_service` test factory**: **the only `PLR0917` suppression kept**, with an inline justification. It mirrors `BriefingService` but has 37 positional call sites across `test_service.py`; forcing keyword-only there would be disproportional churn with no structural benefit. ## Infra Also bumps the prek ruff hook to v0.16.0 to match the uv lockfile, so local hooks and CI agree on whether `BLE001` fires (the root cause of the `RUF100` findings). ## Verification - `uv run ruff check .` — clean - `prek run --all-files` — clean - `uv run pytest --cov --cov-branch` — 1338 passed; coverage unaffected (pure refactor, no tests removed) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Improved service-status message handling for more consistent validation and persistence. * Standardized service configuration and language settings to reduce setup ambiguity. * Preserved existing briefing, notification, geocoding, and service-status behavior. * **Chores** * Updated development linting tools and streamlined code quality checks. * **Tests** * Refined automated coverage to reflect the updated service and message-handling interfaces. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
renovate
Bot
force-pushed
the
renovate/cryptography-50.x
branch
from
August 4, 2026 03:04
54cabe2 to
919109d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
>=45,<50→>=50,<51Release Notes
pyca/cryptography (cryptography)
v50.0.0Compare Source
Configuration
📅 Schedule: (in timezone Asia/Shanghai)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.