-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mass matrix between two field PtrList #552
Conversation
To alleviate RAM issue with large meshes
Sparse mass matrix
for (int i=0; i<V.size(); i++) | ||
{ | ||
M += V(i) * F.transpose().topRows(Msize).col(i) * F.leftCols(Msize).row(i); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? I think the vectorized version should be considerably faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that I had some memory issue for large mesh (mesh size ~ 10^6).
I will double check.
And anyway, I should probably do something that does not slow down the algorithm in the "small mesh case".
if (consider_volumes) | ||
{ | ||
Eigen::VectorXd V = getMassMatrixFV(modes[0]); | ||
for (int i=0; i<V.size(); i++) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think also this one can be written as the previous one
Changing M computation to handle RAM issues for high resolution runs
Florian corrected this merge request. |
I close this merge request and I will create a new one, from a dedicated branch of my fork (up to date with ITHACA-FV/master) |
No description provided.