Skip to content

Pulling latest definitions moved to script generator #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pulling latest definitions moved to script generator #77

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4434ba4
Pulling latest definitions moved to script generator
Alistair-McGann-Tessella Jun 16, 2020
bc5242f
Merge branch 'master' into Ticket5026
Tom-Willemsen Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions installation_and_upgrade/ibex_install_utils/install_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ def run_instrument_install(self):
self._system_tasks.update_web_dashboard()
self._system_tasks.update_kafka_topics()
self._system_tasks.put_autostart_script_in_startup_area()
self._python_tasks.update_script_definitions()

def run_instrument_deploy(self):
"""
Expand Down Expand Up @@ -188,7 +187,6 @@ def run_instrument_deploy_main(self):
self._system_tasks.apply_changes_noted_in_release_notes()
self._system_tasks.update_release_notes()
self._system_tasks.reapply_hotfixes()
self._python_tasks.update_script_definitions()

def run_instrument_deploy_pre_stop(self):
"""
Expand Down
10 changes: 0 additions & 10 deletions installation_and_upgrade/ibex_install_utils/tasks/python_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,6 @@ def install_genie_python3(self):
self._file_utils.mkdir_recursive(APPS_BASE_DIR)
RunProcess(self._genie_python_3_source_dir, "genie_python_install.bat").run()

@task("Update script generator script definitions")
def update_script_definitions(self):
"""
Update (or at least ask the user to update) the script definitions used by the script generator.
"""
if os.path.exists("C:\\ScriptGeneratorConfigs") or os.path.exists("C:\\ScriptDefinitions"):
self.prompt.prompt("Update the script definitions for the script generator (likely in C:\\ScriptDefinitions or C:\\ScriptGeneratorConfigs)." + \
"Check with the scientists that it is ok to do this." + \
"You can do it by git pull, you may need to merge changes made on the instrument.")

@task("Change genie_python shortcuts to python 3")
def change_shortcuts_to_python_3(self):
"""
Expand Down