Skip to content

Conversation

@Tom-Willemsen
Copy link
Member

@Tom-Willemsen Tom-Willemsen commented Oct 25, 2018

Description of work

Fixes an implicit link between a source & copied synoptic component's macros.

Ticket

ISISComputingGroup/IBEX#3697

Acceptance criteria

  • Workflow in ticket is no longer broken

Unit tests

Added a test simulating the workflow in ticket

System tests

This is adequately tested by unit tests; system tests at this level of detail not needed.

Documentation

N/a


Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@ghost ghost merged commit b841070 into master Oct 26, 2018
@ghost ghost deleted the Ticket3697_fix_synoptic_copy branch October 26, 2018 09:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants