Skip to content

Conversation

@AdrianPotter
Copy link
Contributor

Description of work

  • I've refactored the Caen JS scripts into Python
  • I've fixed a bug where empty channels were being added to the Summary Maintenance list. On ZOOM this will manifest as disconnected blocks after channel x not being displayed on that screen
  • I've added macros to allow configuration of the maximum number of channels, slots and crates
  • The default values for the above are preserved from the JS script if no value is entered

Ticket

ISISComputingGroup/IBEX#3002

Acceptance criteria

  • Where no macros entered, behaviour of the screens is preserved. I've tested with my GUI pointing at ZOOM, and by using a clone of ZOOM's configs locally.
  • The Summary Maintenance list of power supplies responds to changes to the OPI macros
    • I found the easiest way to test this was to create a local device screen while my GUI was pointing at my machine, then switch instrument to ZOOM. You can then compare their existing CAEN device screen and your local one.

Unit tests

  • OPI scripts are not unit tested. Perhaps they should be, but we currently have no way of automating them. Perhaps that's something to look at in the future.

System tests

  • None. OPI changes not system tested

Documentation

  • No change

Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

Copy link
Contributor

@John-Holt-Tessella John-Holt-Tessella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert to new style opi

Good though it feels much cleaner

</macro>
<macro>
<name>MAX_CHANNELS</name>
<description>The maximum number of channels per slot per crate to display (default: 10)</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max default 25 to include ZOOM_M4

@John-Holt-Tessella
Copy link
Contributor

John-Holt-Tessella commented May 21, 2018

Couple extra items:

On HVChannelMonitorSummary.opi:

  • the power led should be connected to pwonoff:fbk (check with @KathrynBaker )
  • there should be an on/off button to switch power on and off (check with @KathrynBaker )
  • the "off_color" LED should be ISIS_Green_LED_Off

@AdrianPotter
Copy link
Contributor Author

Just awaiting confirmation from @KathrynBaker

@KathrynBaker
Copy link
Member

Those both sound fine to me, this is an old OPI, so it was unlikely to conform to current standards.

@jeremyspencer39171 jeremyspencer39171 merged commit db3ad4b into master May 22, 2018
@jeremyspencer39171 jeremyspencer39171 deleted the Ticket3002_Refactor_and_extend_CAEN_scripts branch May 22, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants