-
Notifications
You must be signed in to change notification settings - Fork 0
Ticket3002 refactor and extend caen scripts #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket3002 refactor and extend caen scripts #689
Conversation
John-Holt-Tessella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please convert to new style opi
Good though it feels much cleaner
| </macro> | ||
| <macro> | ||
| <name>MAX_CHANNELS</name> | ||
| <description>The maximum number of channels per slot per crate to display (default: 10)</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max default 25 to include ZOOM_M4
|
Couple extra items: On
|
|
Just awaiting confirmation from @KathrynBaker |
|
Those both sound fine to me, this is an old OPI, so it was unlikely to conform to current standards. |
Description of work
xnot being displayed on that screenTicket
ISISComputingGroup/IBEX#3002
Acceptance criteria
Unit tests
System tests
Documentation
Code Review
Final Steps