Ticket8788 dependency updates #1828
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public class CheckboxLabelProviderTest { | ||
|
|
||
|
|
||
| public class mockSelectionListener implements Listener { |
Check notice
Code scanning / CodeQL
Inner class could be static Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 days ago
To fix the problem, the inner class mockSelectionListener should be made static. This can be done by adding the static keyword to its declaration inside CheckboxLabelProviderTest. This change will prevent all instances of mockSelectionListener from implicitly storing a reference to the outer CheckboxLabelProviderTest instance, improving memory usage and code clarity. Make sure to only modify the class declaration at line 52 in the provided file; since the class itself does not use outer class members, no further changes are needed elsewhere.
| @@ -49,7 +49,7 @@ | ||
| */ | ||
| public class CheckboxLabelProviderTest { | ||
|
|
||
| public class mockSelectionListener implements Listener { | ||
| public static class mockSelectionListener implements Listener { | ||
| private EventListener eventListener; | ||
| @Override | ||
| public void handleEvent(Event event) { |
Description of work
Add your own description here
Ticket
Link to Ticket
Acceptance criteria
List the acceptance criteria for the PR. The aim is provide information to help the reviewer
Unit tests
Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer
System tests
Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer
Documentation
Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer
Code Review
check_opi_format.pyscript in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?Final Steps