Skip to content

Conversation

@NikolaRoev
Copy link

@NikolaRoev NikolaRoev commented Dec 14, 2022

Description of work

Added TYPE OPI macro, for each controller, which hides the park box for fermi choppers.

Ticket

ISISComputingGroup/IBEX#6100

Acceptance criteria

List the acceptance criteria for the PR. The aim is provide information to help the reviewer

Unit tests

Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer

System tests

Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer

Documentation

Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer


Code Review

Final Steps

@NikolaRoev NikolaRoev self-assigned this Dec 14, 2022
@pheest
Copy link
Contributor

pheest commented Dec 19, 2022

check_opi_format.py generates these messages:

SKFChopper.opi
AssertionError: Label on line 778 with text 'SKF G5 Chopper Controllers' is not title case
AssertionError: TextInput on line 204 (Chopper Name) was not in a grouping container
SKFChopper_Master.opi
AssertionError: Label on line 614 with text 'Phase Error:' is not sentence case
Label on line 908 with text 'Phase Locked:' is not sentence case
Label on line 1784 with text 'Parked Position:' is not sentence case
Label on line 1825 with text 'Shaft Angle:' is not sentence case

@pheest pheest merged commit 7168060 into master Dec 20, 2022
@NikolaRoev NikolaRoev deleted the Ticket6100_fermi_chopper_support branch January 18, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants