-
Notifications
You must be signed in to change notification settings - Fork 0
Custom Magnet PSU synoptic OPI for RIKENFE #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so that they open relevant PSU OPIs
…r and created individual table opi
Rename recourse label names in OPI to be more descriptive of attributes
Update opi_info with basic information about RIKEN magnet PSU to view in client
Rename port tab components in RIEKN Magnet PSU Synoptic to better describe components as part of refacter
Create a third prototype opi for RIKEN to choose from as part of deciding on an OPI design for the magnet PSU synoptic
Refactor opi to label elements in more detail
Create a table for eacvh port populated wiht default values until IOCs exist to replace values with. Update Macros to pass over IOC info from main opi to port tables
Tom-Willemsen
requested changes
Dec 9, 2022
base/uk.ac.stfc.isis.ibex.opis/resources/RIKEN/Magnet/rb2_2port_shared.opi
Outdated
Show resolved
Hide resolved
base/uk.ac.stfc.isis.ibex.opis/resources/RIKEN/Magnet/rb2_1port_shared.opi
Outdated
Show resolved
Hide resolved
base/uk.ac.stfc.isis.ibex.opis/resources/RIKEN/Magnet/indiviudal_port_table_port_shared.opi
Outdated
Show resolved
Hide resolved
Tom-Willemsen
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Created a "Synoptic" OPI for the magnet powersupplies on RIKENFE
Ticket
Link to Ticket
Acceptance criteria
Code Review
check_opi_format.pyscript in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?Final Steps