Skip to content

Conversation

@Chsudeepta
Copy link
Contributor

@Chsudeepta Chsudeepta commented Sep 15, 2025

Description of work

Added logic to allow configuration of alarm for a block.

To test

Fixes me

Acceptance criteria

  1. The code should satisfy the coding standards
  2. All the system tests should pass
  3. The Block Server should be able to process both the case - where alarm config is present and old generation files where alarm configurations are missing
  4. When block level alarm configurations are set from the GUI, they should be persisted in the block.xml for the Configuration or Component.
  5. Values set in the block.xml should reflect in the Add/Edit block GUI dialog
  6. Values set in the block.xml should impact the way the alarms happen and appear on the Alarms Tree in the GUI.

Code Review

  • Is the code of an acceptable quality?
  • Has the author taken into account the multi-threaded nature of the code?
  • Have the changes been recorded appropriately in a PR for release notes?
  • Has the manual system tests spreadsheet been updated?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.

Final steps

  • Reviewer has updated the submodule in the main EPICS repo? See Reviewing work for the subModules of EPICS in the Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@Chsudeepta
Copy link
Contributor Author

image The error coming above is expected as the .xsd is also changed and part of another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants