Skip to content

Conversation

@DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Jan 7, 2019

Description of work

Modified the ISIS logger to only send valid XML to the log server
See ISISComputingGroup/IBEX#3240

To Test

  • Make sure you have a running instrument
  • Create a new ISISLogger and send unicode chars to it
  • Confirm that no error messages like the original ticket are seen in the IOC LOG
  • Confirm that the message ends up in the msg_log
  • Confirm that the blockserver correctly starts/restarts iocs

Code Review

  • Is the code of an acceptable quality?
  • Has the author taken into account the multi-threaded nature of the code?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?
  • Has the manual system tests spreadsheet been updated?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.

Final steps

  • Reviewer has updated the submodule in the main EPICS repo? See Reviewing work for the subModules of EPICS in the Git workflow page for details.
  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@ISISBuildServer
Copy link

34% (0.0%) vs master 34%

if not force and ioc.startswith(IOCS_NOT_TO_STOP):
return
try:
auto = self._proc.get_autorestart(ioc)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that my refactoring removed this line, which was the one originally failing the ticket.

@ISISBuildServer
Copy link

34% (-0.04%) vs master 34%

@aaron-long
Copy link
Contributor

See the added notes in the main post of ticket thread.

The issue is fixed for the blockserver but IOC's can still cause the putlogging from the IOC Log Server to die.

@ISISBuildServer
Copy link

34% (+0.83%) vs master 33%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants