-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate guestbook email field #11022
validate guestbook email field #11022
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test this but it looks right.
I don't believe it's possible to fill in a guestbook via API so it's understandable that there is no API test.
Once API tests show as passing I'll move it to "ready for QA".
Moving back to in progress. There is an issue caused by this fix that does affect an API Caused by: jakarta.validation.ConstraintViolationException: One or more Bean Validation constraints were violated while executing Automatic Bean Validation on callback event: prePersist for class: edu.harvard.iq.dataverse.GuestbookResponse. Please refer to the embedded constraint violations for details. |
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test this but the changes and updated changes look good and API tests are passing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11022/6/testReport/
Approved!
Testing passed - Merging PR |
What this PR does / why we need it: Guestbook email field is not validated.
Which issue(s) this PR closes: #10661
Special notes for your reviewer:
Suggestions on how to test this: Test existing code and new code entering empty. valid, and invalid email addresses.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: