Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate guestbook email field #11022

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

stevenwinship
Copy link
Contributor

@stevenwinship stevenwinship commented Nov 15, 2024

What this PR does / why we need it: Guestbook email field is not validated.

Which issue(s) this PR closes: #10661

Special notes for your reviewer:

Suggestions on how to test this: Test existing code and new code entering empty. valid, and invalid email addresses.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
image

Is there a release notes update needed for this change?:

Additional documentation:

@stevenwinship stevenwinship self-assigned this Nov 15, 2024
@stevenwinship stevenwinship added Type: Bug a defect Size: 10 A percentage of a sprint. 7 hours. FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) labels Nov 15, 2024

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Nov 15, 2024

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

@pdurbin pdurbin self-assigned this Nov 15, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but it looks right.

I don't believe it's possible to fill in a guestbook via API so it's understandable that there is no API test.

Once API tests show as passing I'll move it to "ready for QA".

@stevenwinship
Copy link
Contributor Author

Moving back to in progress. There is an issue caused by this fix that does affect an API

Caused by: jakarta.validation.ConstraintViolationException: One or more Bean Validation constraints were violated while executing Automatic Bean Validation on callback event: prePersist for class: edu.harvard.iq.dataverse.GuestbookResponse. Please refer to the embedded constraint violations for details.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10661-guestbook-email-field-not-validated
ghcr.io/gdcc/configbaker:10661-guestbook-email-field-not-validated

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but the changes and updated changes look good and API tests are passing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11022/6/testReport/

Approved!

@pdurbin pdurbin removed their assignment Nov 15, 2024
@ofahimIQSS ofahimIQSS self-assigned this Nov 18, 2024
@ofahimIQSS
Copy link
Contributor

Testing passed - Merging PR
Testing of 10661.docx

@ofahimIQSS ofahimIQSS merged commit c0c6b08 into develop Nov 19, 2024
19 checks passed
@ofahimIQSS ofahimIQSS deleted the 10661-guestbook-email-field-not-validated branch November 19, 2024 16:42
@ofahimIQSS ofahimIQSS removed their assignment Nov 19, 2024
@pdurbin pdurbin added this to the 6.5 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Guestbook email field does not check email validity
3 participants