review: fix: Crashes when records contained static fields #6095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spoon tried to remove the field to prevent record field duplication. This fails for static fields, which do not exist (yet). For these, spoon passed null to the remove method, which failed with an exception. We now check for the modifier and null explicitly.
I-Al-Istannen
force-pushed
the
fix/crash-with-record-static-fields
branch
from
5371823 to
b546253
Compare
I-Al-Istannen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spoon tried to remove the field to prevent record field duplication. This fails for static fields, which do not exist (yet). For these, spoon passed null to the remove method, which failed with an exception. We now check for the modifier and null explicitly.
Reported by @Luro02.