review: fix: issue #5868 with invalid parents for elements in model #5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-Al-Istannen
requested changes
Jun 26, 2024
src/test/java/spoon/testing/utils/ModelTestParameterResolver.java
Outdated
Show resolved
Hide resolved
I-Al-Istannen
force-pushed
the
feature/invalid-parents-in-model
branch
from
6bedbe3 to
a7fd7d7
Compare
Luro02
changed the title
Luro02
changed the title
Otherwise it will become part of the public API by accident
I-Al-Istannen
force-pushed
the
feature/invalid-parents-in-model
branch
from
9b70b05 to
fb4b9aa
Compare
|
@SirYwell ping :) |
SirYwell
requested changes
Oct 29, 2024
src/main/java/spoon/reflect/visitor/ModelConsistencyChecker.java
Outdated
Show resolved
Hide resolved
src/main/java/spoon/reflect/visitor/ModelConsistencyChecker.java
Outdated
Show resolved
Hide resolved
SirYwell
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR might conflict with my other PR #5801