review: chore: deprecate public CtTypeReference fields in TypeFactory #5646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirYwell
changed the title
I-Al-Istannen
requested changes
Feb 6, 2024
I-Al-Istannen
approved these changes
Feb 9, 2024
I-Al-Istannen
force-pushed
the
chore/deprecate-factory-constants
branch
from
3388617 to
ef1b931
Compare
|
If you merge #5662 and rebase ontop of the new java17 branch, the CI should be green :) |
MartinWitt
added a commit
that referenced
this pull request
Feb 11, 2024
Co-authored-by: I-Al-Istannen <[email protected]> Co-authored-by: Martin Wittlinger <[email protected]>
I-Al-Istannen
added a commit
that referenced
this pull request
Apr 3, 2024
Co-authored-by: I-Al-Istannen <[email protected]> Co-authored-by: Martin Wittlinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct access allows mutating the base object, which should be prevented.