review: test: introduce generated AssertJ asserts #5644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The java 21 failures are related to:
|
|
Okay @SirYwell's AssertJ version was built a long time ago in a galaxy far, far away. Updating AssertJ will fix this. |
SirYwell
force-pushed
the
feature/assertj-codegen
branch
from
a5afb52 to
0c8568e
Compare
SirYwell
changed the title
The update adds an improvement for CtTypeReference processing in the AssertJCodegen.java file. It introduces the capacity to include wildcard type parameters when the type reference is created. This amend maintains the production of a complete, reliable, usable type reference, ultimately improving the test assertion performance.
Added a new line in the AssertJCodegen.java file to set super interfaces for the ctInterface object. This addition enhances the code generation test assertions.
Reduced the verbosity of the "codegen" script within the flake.nix file. This refactor makes the script more concise, resulting in code that's easier to understand. It still retains full functionality, including testing, applying spotless, and checking for uncommitted changes.
SirYwell
force-pushed
the
feature/assertj-codegen
branch
from
0c8568e to
77d7c24
Compare
The .github/workflows/tests.yml file has been modified to run codegen checks instead of executing tests with coverage. The environmental variables for the GitHub token and PR number have been removed, and the name for this action has been updated to reflect these changes.
The spotless-maven-plugin version has been upgraded from 2.41.1 to 2.43.0, and the palantirJavaFormat version has been boosted from 2.39.0 to 2.40.0. Also, Javadoc formatting has been enabled on palantirJavaFormat and the command for running codegen checks in the tests workflow file has been adjusted.
MartinWitt
added a commit
that referenced
this pull request
Feb 11, 2024
Co-authored-by: I-Al-Istannen <[email protected]> Co-authored-by: Martin Wittlinger <[email protected]>
I-Al-Istannen
added a commit
that referenced
this pull request
Apr 3, 2024
Co-authored-by: I-Al-Istannen <[email protected]> Co-authored-by: Martin Wittlinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhanced support for AssertJ for our test infrastructure. Specialized Assert classes allow directly testing for specific metamodel properties, reducing the repetitive code we currently write in tests.
The classes and interfaces are automatically generated, methods added to interfaces manually will persist when regenerating. To ensure consistency, we have a CI check that fails if regeneration is needed.