review: fix: correctly print enum constants in switches pre Java 21 #5636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-Al-Istannen
approved these changes
Jan 24, 2024
MartinWitt
reviewed
Jan 27, 2024
Comment on lines
64
to
+69
| private static CtModel createModelFromString(String code) { | ||
| return createModelFromString(code, 21); | ||
| } | ||
| private static CtModel createModelFromString(String code, int complianceLevel) { | ||
| Launcher launcher = new Launcher(); | ||
| launcher.getEnvironment().setComplianceLevel(14); | ||
| launcher.getEnvironment().setComplianceLevel(complianceLevel); |
There was a problem hiding this comment.
More a note to myself that we have this method atleast 10 times already.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes in #5610, enum constants in switch cases might have been printed incorrectly.