fix: Add thread-safety to TypeAdaptor method adaptation #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think one main issue is that other accesses to the method body that don't go through this lock won't care and might see invalid state. But @I-Al-Istannen surely can weigh in on this. |
|
Yea, this is not quite enough. We could add a flag to the adapt method that defines whether we are only interested in the signature 🤔 |
I-Al-Istannen
force-pushed
the
fix/issue5619
branch
from
1eb34e2 to
56845a5
Compare
When checking whether a method overrides another, we need to adapt both methods to a common ground. In an early version this required cloning the entire method, including its body, to perform the adaption. PR #4862 fixed this by nulling the body before cloning the method and then restoring it afterwards. This operation is not thread safe, as it may write concurrently and also modifies what other parallel threads might see when traversing the model. This patch now introduces a private override specifying whether we are only interested in the signature. If that is the case, we explicitly construct a new method using the factory instead of cloning the original. Closes: #5619
I-Al-Istannen
force-pushed
the
fix/issue5619
branch
from
56845a5 to
ca1bf5f
Compare
|
@SirYwell feel free to merge |
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #5619, but I am not sure if locking on a method parameter is more elegant than calling clone.