review: chore: compile spoon with Java 17 #5588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Java 11 from the tests.yml matrix in favor of more recent versions to ensure compatibility with updated dependencies. Update setup-java actions accordingly.
|
@MartinWitt could you take a look at the changes please? |
Luro02
reviewed
Dec 29, 2023
There was a problem hiding this comment.
Shoudn't the java version in jreleaser.yml be changed to 17 as well?
Lines 17 to 20 in 00717fa
I-Al-Istannen
added a commit
that referenced
this pull request
Apr 3, 2024
Co-authored-by: I-Al-Istannen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully brings spoon to Java 17. Small adjustments to tests were needed.