review: chore: Switch to oracle JDK 21 in CI until nixpkgs catches up #5468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-Al-Istannen
force-pushed
the
chore/jdk-21-ci
branch
from
bcdc50e to
fdbfac4
Compare
I-Al-Istannen
changed the title
|
Would it make sense to also drop Java 20 and add 22-ea? |
|
Sounds fine to me |
I-Al-Istannen
force-pushed
the
chore/jdk-21-ci
branch
6 times, most recently
from
e3b435d to
7df70a1
Compare
|
This PR requires the java 21 fix, or? Will this conflict with the lockfile update from renovate? |
|
It requires the 21 fix, but does not conflict. |
I-Al-Istannen
force-pushed
the
chore/jdk-21-ci
branch
from
7df70a1 to
3a01180
Compare
I-Al-Istannen
force-pushed
the
chore/jdk-21-ci
branch
from
3a01180 to
5856ec5
Compare
MartinWitt
approved these changes
Oct 2, 2023
|
Thanks @SirYwell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now update the CI to use the (oracle) JDK 21 GA build.