review: fix: Subtyping relationships for arrays #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-Al-Istannen
force-pushed
the
fix/issue-5462
branch
from
3652bb5 to
37c2ccb
Compare
| throw new SpoonException("There are no source level array type declarations"); | ||
| } | ||
| Class<?> actualClass = base.getActualClass(); | ||
| // Arrays of different shapes are not subtypes |
There was a problem hiding this comment.
This isn't true?
new Object[0][0] instanceof Object[]
$3 ==> true
This is a consequence of
- If S and T are both reference types, then S[] >1 T[] iff S >1 T.
- Object >1 Object[]
unless I'm missing some context here.
There was a problem hiding this comment.
Right, I missed that when reading the rules apparently. That is a bit unfortunate. I guess I need to peel of layers until one or the other reaches a non-array value.
There was a problem hiding this comment.
Addressed (hopefully :P). Thanks :)
I-Al-Istannen
changed the title
SirYwell
requested changes
Sep 26, 2023
SirYwell
approved these changes
Sep 26, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was a bit of a doozy.
Array subtyping needs to be special cased, as Spoon is not able to build a
CtTypefor source-level arrays. Similarly, once we are given a shadowCtTypethat refers to an array type, we need to unpack to find the real type to build our hierarchy for. We can not just fall back to the javaClass#isAssignableFrom, as the super type reference might not be shadowable.Closes #5462.