review: fix: Use CtSuperAccess when implicitly accessing superclass field #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-Al-Istannen
force-pushed
the
fix/implicit-super-access
branch
2 times, most recently
from
12a258a to
ea9a0ad
Compare
I-Al-Istannen
changed the title
I-Al-Istannen
changed the title
SirYwell
reviewed
Aug 31, 2023
| @@ -364,12 +365,32 @@ <T> CtFieldAccess<T> createFieldAccess(SingleNameReference singleNameReference) | |||
| if (ref.isStatic() && !ref.getDeclaringType().isAnonymous()) { | |||
| va.setTarget(jdtTreeBuilder.getFactory().Code().createTypeAccess(ref.getDeclaringType(), true)); | |||
| } else if (!ref.isStatic()) { | |||
| va.setTarget(jdtTreeBuilder.getFactory().Code().createThisAccess(jdtTreeBuilder.getReferencesBuilder().getTypeReference(singleNameReference.actualReceiverType), true)); | |||
| CtTypeReference<?> owningType = jdtTreeBuilder.getReferencesBuilder().getTypeReference(singleNameReference.actualReceiverType); | |||
| if (enclosingClassHasFieldWithName(singleNameReference)) { | |||
There was a problem hiding this comment.
It seems like singleNameReference.actualReceiverType == singleNameReference.fieldBinding().declaringClass does the job too, however I'm wondering if actualReceiverType is what we want here for the owning type?
There was a problem hiding this comment.
@I-Al-Istannen can you resolve this?
fix: Do not print implicit super fix: Do not force-qualify implicit super elements
I-Al-Istannen
force-pushed
the
fix/implicit-super-access
branch
from
ea9a0ad to
f8df670
Compare
I-Al-Istannen
force-pushed
the
fix/implicit-super-access
branch
from
f8df670 to
d9f360b
Compare
SirYwell
reviewed
Oct 3, 2023
SirYwell
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5221