-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adopt jspecify #5384
refactor: adopt jspecify #5384
Conversation
85b7e90
to
a3f2a58
Compare
When annotating a return type of a method by jspecify's public @Nullable String foo() {
return ""
} That is to say, the annotation is applied directly to the return type. But annotations in that position don't pass Qodana's checks (MissortedModifiers). |
This is configurable in IntelliJ, but I don't know if/how it can be configured using the |
Hey,
The current Qodana config does not allow this directly, but you could try
adding the `.idea` config file to the repo after changing the setting in IJ.
If this does not work, disabling the rule with a comment why is also fine
for me. Otherwise, great progress.
|
I tried the latter, as I could not find any information that the |
@SirYwell can you provide the config file with the changed IJ setting? |
a813617
to
0c1b514
Compare
Okay, I give up. It seems to work locally, but what do I know. Let's disable that modifier check. |
@I-Al-Istannen so we merge and fix this at a later stage? |
Thanks @tenax66 for your work. |
This is a pull request for issue #5320 .
jspecify
.@Nullable
annotation to several packages as a first step:spoon
,spoon.compiler
,spoon.metamodel
andspoon.pattern.internal
.Note: This pull request does not include checks for annotations. We may use jspecify-reference-checker in the future.